feat: Add the custom unit option of relativeTime
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ktmouk is attempting to deploy a commit to the next-intl Team on Vercel. A member of the Team first needs to authorize it. |
ktmouk
changed the title
relativeTimerelativeTime
ktmouk
changed the title
relativeTimerelativeTime
ktmouk
changed the title
relativeTimerelativeTime
ktmouk
commented
Oct 15, 2023
Comment on lines
18
to
35
| const UNIT_SECONDS = { | ||
| second: SECOND, | ||
| seconds: SECOND, | ||
| minute: MINUTE, | ||
| minutes: MINUTE, | ||
| hour: HOUR, | ||
| hours: HOUR, | ||
| day: DAY, | ||
| days: DAY, | ||
| week: WEEK, | ||
| weeks: WEEK, | ||
| month: MONTH, | ||
| months: MONTH, | ||
| quarter: QUARTER, | ||
| quarters: QUARTER, | ||
| year: YEAR, | ||
| years: YEAR | ||
| } as const; |
There was a problem hiding this comment.
I added quarter and plural forms to make it match RelativeTimeFormatUnit type.
ktmouk
commented
Oct 15, 2023
| years: YEAR | ||
| } as const; | ||
|
|
||
| function resolveRelativeTimeUnit(seconds: number) { |
There was a problem hiding this comment.
I didn't add quarter here because I believe we don't want to use the quarter unit in most cases.
amannn
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
relativeTimeoptions to support custom units and updates the documentation accordingly.Close: #565